pageserver: fix AUX key vectored get validation #7018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The value reconstruct of AUX_FILES_KEY from records is not deterministic since it uses a hash map under the hood.
This caused vectored get validation failures when enabled in staging.
Summary of changes
Deserialise AUX_FILES_KEY blobs comparing. All other keys should reconstruct deterministically,
so we simply compare the blobs.
Testing
Tested this locally with data extracted from a tenant which ran into this problem in staging.
Checklist before requesting a review
Checklist before merging